Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxl-ui): cxl-app-layout add padding only on desktop #425

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(cxl-ui): cxl-app-layout add padding only on desktop #425

merged 1 commit into from
Jul 19, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jul 16, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt July 16, 2024 13:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.24 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.99 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 275.83 KB (0%)

pawelkmpt
pawelkmpt reviewed Jul 19, 2024
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use lumo values when possible. I adjusted the code. left/right padding size is not identical (80px instead of 75.5px) but looks as good as initially.

@pawelkmpt pawelkmpt merged commit 13936c0 into master Jul 19, 2024
1 check passed
@pawelkmpt pawelkmpt deleted the anoblet/fix/layout branch July 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @pawelkmpt